-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Define YAML tables for DWI/ASL/(i)EEG/micr/beh metadata #1029
Merged
tsalo
merged 12 commits into
bids-standard:schema/sidecar_validation
from
tsalo:more-sidecar-sections
Apr 7, 2022
Merged
[SCHEMA] Define YAML tables for DWI/ASL/(i)EEG/micr/beh metadata #1029
tsalo
merged 12 commits into
bids-standard:schema/sidecar_validation
from
tsalo:more-sidecar-sections
Apr 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
added
the
schema
Issues related to the YAML schema representation of the specification. Patch version release.
label
Mar 17, 2022
tsalo
commented
Mar 17, 2022
Comment on lines
+10
to
+16
# NOTE: I don't think this can be schemafied, since it depends on owner intent. | ||
MRIDiffusionMultipart: | ||
selectors: | ||
- modality == "MRI" | ||
- datatype == "dwi" | ||
fields: | ||
MultipartID: REQUIRED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how we should handle MultipartID, since its requirement level depends on owner knowledge, rather than any validatable elements of the dataset.
22 tasks
tsalo
changed the title
[SCHEMA] Define YAML tables for DWI and ASL data
[SCHEMA] Define YAML tables for DWI, ASL, EEG, and iEEG data
Mar 17, 2022
tsalo
changed the title
[SCHEMA] Define YAML tables for DWI, ASL, EEG, and iEEG data
[SCHEMA] Define YAML tables for DWI/ASL/(i)EEG/micr/beh data
Mar 18, 2022
tsalo
changed the title
[SCHEMA] Define YAML tables for DWI/ASL/(i)EEG/micr/beh data
[SCHEMA] Define YAML tables for DWI/ASL/(i)EEG/micr/beh metadata
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
schema
Issues related to the YAML schema representation of the specification. Patch version release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None, but is related to #1014.
Changes proposed:
schema/rules/sidecars/dwi.yaml
file with metadata rules for DWI data.schema/rules/sidecars/asl.yaml
file with metadata rules for ASL data.schema/rules/sidecars/beh.yaml
file with metadata rules for behavioral (events/beh) data.schema/rules/sidecars/continuous.yaml
file with metadata rules for physiological and stimulus data.schema/rules/sidecars/eeg.yaml
file with metadata rules for EEG data.schema/rules/sidecars/ieeg.yaml
file with metadata rules for iEEG data.schema/rules/sidecars/micr.yaml
file with metadata rules for microscopy data.schema/rules/sidecars/mri.yaml
,schema/rules/sidecars/anat.yaml
, andschema/rules/sidecars/entities.yaml
files.